Update github.com/cespare/xxhash/v2 to v2.1.2 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
force-pushed
the
updatexxhash
branch
2 times, most recently
from
a2013d1 to
303abed
Compare
zshi-redhat
reviewed
Sep 10, 2021
| @@ -1,3 +1,4 @@ | |||
| //go:build tools | |||
There was a problem hiding this comment.
Is this change still needed?
There was a problem hiding this comment.
Yes, that's why I pushed 3 times :-)
CI was complaining about it
There was a problem hiding this comment.
wondering if we can remove the following line+build tools.
There was a problem hiding this comment.
I think we can't. CI compares the generated file with what's in this PR and complains if they are different.
There was a problem hiding this comment.
diff --git a/hack/tools.go b/hack/tools.go
index 7a21725c..d1427a67 100644
--- a/hack/tools.go
+++ b/hack/tools.go
@@ -1,4 +1,4 @@
-// +build tools
+//go:build tools
This is if I remove the other line
|
/lgtm |
fedepaol
force-pushed
the
updatexxhash
branch
from
a875b5e to
01428a9
Compare
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54) Here we bump up the dependency to solve the issue. Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
updatexxhash
branch
from
01428a9 to
c1edce4
Compare
|
/lgtm |
zshi-redhat
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/cespare/xxhash/v2 v2.1.1 is incompatible with Go 1.17 (see cespare/xxhash#54)
Here we bump up the dependency to solve the issue.