Restart device plugin pod after node policy applied #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to restart device plugin pod after node policy applied and all SR-IOV Network Config Daemon plugins finished. E.g.: Generic plugin applies SR-IOV Network Node Policy and creates VFs. That's mean we need to restart device plugin pod to found newly created devices. Related k8snetworkplumbingwg/sriov-network-device-plugin#276
|
@e0ne Could you help me understand why we need to move the restart of device plugin after the completeDrain? |
|
@zshi-redhat thanks for the review. the idea of my patch is to restart device plugin pod once after all sriov plugins applied. Digger deeper in the code, I agree that it should be done before completeDrain. It means this PR is the same as #173 but with different commit message |
|
it's duplicate of #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to restart device plugin pod after node policy applied
and all SR-IOV Network Config Daemon plugins finished. E.g.:
Generic plugin applies SR-IOV Network Node Policy and creates
VFs. That's mean we need to restart device plugin pod to found
newly created devices.
Related k8snetworkplumbingwg/sriov-network-device-plugin#276