e2e: Allow testing custom cni and dp image #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
bn222
reviewed
Oct 10, 2023
| @@ -189,7 +189,7 @@ echo "## build daemon image" | |||
| podman build -t "${SRIOV_NETWORK_CONFIG_DAEMON_IMAGE}" -f "${root}/Dockerfile.sriov-network-config-daemon" "${root}" | |||
|
|
|||
| echo "## build webhook image" | |||
| podman build -t "${SRIOV_NETWORK_WEBHOOK_IMAGE}" -f "${root}/Dockerfile.webhook" "${root}" | |||
| podman `build` -t "${SRIOV_NETWORK_WEBHOOK_IMAGE}" -f "${root}/Dockerfile.webhook" "${root}" | |||
There was a problem hiding this comment.
That went by mistake. Thanks for catching it
zeeke
force-pushed
the
e2e-inject-images
branch
from
b5ca4bf to
e8cf842
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
bn222
reviewed
Oct 12, 2023
|
|
||
| if [[ -v LOCAL_SRIOV_DEVICE_PLUGIN_IMAGE ]]; then | ||
| export SRIOV_DEVICE_PLUGIN_IMAGE="$registry/$NAMESPACE/sriov-network-device-plugin:latest" | ||
| echo "## Pushing ${LOCAL_SRIOV_DEVICE_PLUGIN_IMAGE} to cluster iamge ${SRIOV_SRIOV_DEVICE_PLUGIN_IMAGE}" |
There was a problem hiding this comment.
This is a copy paste from above (the typo even got copied). Create a function instead to echo + tag + push.
| if [[ -v LOCAL_SRIOV_DEVICE_PLUGIN_IMAGE ]]; then | ||
| export SRIOV_DEVICE_PLUGIN_IMAGE="$registry/$NAMESPACE/sriov-network-device-plugin:latest" | ||
| echo "## Pushing ${LOCAL_SRIOV_DEVICE_PLUGIN_IMAGE} to cluster iamge ${SRIOV_SRIOV_DEVICE_PLUGIN_IMAGE}" | ||
| podman tag ${LOCAL_SRIOV_DEVICE_PLUGIN_IMAGE} ${SRIOV_SRIOV_DEVICE_PLUGIN_IMAGE} |
There was a problem hiding this comment.
SRIOV_SRIOV_DEVICE_PLUGIN_IMAGE has twice SRIOV in it. Is that on purpose?
zeeke
force-pushed
the
e2e-inject-images
branch
from
e8cf842 to
f93387b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/hold |
Pull Request Test Coverage Report for Build 7692695746
💛 - Coveralls |
zeeke
force-pushed
the
e2e-inject-images
branch
from
f93387b to
2a8e70c
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
2a8e70c to
ce2003f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
reviewed
Oct 23, 2023
zeeke
force-pushed
the
e2e-inject-images
branch
from
ce2003f to
aff6239
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
aff6239 to
0ed185e
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
0ed185e to
01ac0a3
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
01ac0a3 to
b4f519a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
1 similar comment
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
e406b5f to
a843b3b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
This is now ready for review, it worked against sriov-cni wip PR: |
SchSeba
reviewed
Nov 11, 2023
|
@adrianchiris , @e0ne can you take a look at this? |
zeeke
force-pushed
the
e2e-inject-images
branch
from
a843b3b to
4ca7d9a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-inject-images
branch
from
4ca7d9a to
111af4c
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Jan 28, 2024
Let `run-e2e-conformance-virtual-ocp.sh` and `run-e2e-conformance-virtual-cluster.sh` deploy clusters with specific SRIOV CNI and Device Plugin images. This will enable other projects to have full end-to-end test CI with operator's suite. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
e2e-inject-images
branch
from
111af4c to
4663412
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Two approvals gathered. |
|
All CI checks green. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
run-e2e-conformance-virtual-ocp.shandrun-e2e-conformance-virtual-cluster.shdeploy clusters with specific SRIOV CNI and Device Plugin images. This will enable other projects to have full end-to-end test CI with the operator's suite.Ref:
cc @adrianchiris @e0ne