Skip to content

Commit

Permalink
Merge pull request #178 from zshi-redhat/crd-v1
Browse files Browse the repository at this point in the history
Use CRD v1 in SriovNetworkPoolConfig patches
  • Loading branch information
pliurh authored Aug 23, 2021
2 parents f635fb9 + 64afcbb commit c608fee
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# The following patch adds a directive for certmanager to inject CA into the CRD
# CRD conversion requires k8s 1.13 or later.
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
Expand Down
21 changes: 10 additions & 11 deletions config/crd/patches/webhook_in_sriovnetworkpoolconfigs.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
# The following patch enables conversion webhook for CRD
# CRD conversion requires k8s 1.13 or later.
apiVersion: apiextensions.k8s.io/v1beta1
# The following patch enables a conversion webhook for the CRD
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: sriovnetworkpoolconfigs.sriovnetwork.openshift.io
spec:
conversion:
strategy: Webhook
webhookClientConfig:
# this is "\n" used as a placeholder, otherwise it will be rejected by the apiserver for being blank,
# but we're going to set it later using the cert-manager (or potentially a patch if not using cert-manager)
caBundle: Cg==
service:
namespace: system
name: webhook-service
path: /convert
webhook:
clientConfig:
service:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1

0 comments on commit c608fee

Please sign in to comment.