fix odd number of key-value in error logs

a recent refactor to logging introduced these issues[1]. fix them to avoid panic during runtime [1] c155c82 Signed-off-by: adrianc <[email protected]>
k8snetworkplumbingwg · Nov 9, 2023 · 7d9eca4 · 7d9eca4
1 parent e35bc9e
commit 7d9eca4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/daemon/daemon.go b/pkg/daemon/daemon.go
@@ -298,7 +298,7 @@ func (dn *Daemon) Run(stopCh <-chan struct{}, exitCh <-chan error) error {
 			log.Log.V(0).Info("Run(): stop daemon")
 			return nil
 		case err, more := <-exitCh:
-			log.Log.Error(err, "got an error", err)
+			log.Log.Error(err, "got an error")
 			if more {
 				dn.refreshCh <- Message{
 					syncStatus:    syncStatusFailed,

diff --git a/pkg/plugins/mellanox/mellanox_plugin.go b/pkg/plugins/mellanox/mellanox_plugin.go
@@ -229,7 +229,7 @@ func getMlnxNicFwData(pciAddress string) (current, next *mlnxNic, err error) {
 
 	out, err := utils.MstConfigReadData(pciAddress)
 	if err != nil {
-		log.Log.Error(err, "mellanox-plugin getMlnxNicFwData(): failed", err)
+		log.Log.Error(err, "mellanox-plugin getMlnxNicFwData(): failed")
 		return
 	}
 	mstCurrentData, mstNextData := utils.ParseMstconfigOutput(out, attrs)

diff --git a/pkg/systemd/systemd.go b/pkg/systemd/systemd.go
@@ -167,7 +167,7 @@ func WriteSriovResult(result *SriovResult) error {
 
 	out, err := yaml.Marshal(result)
 	if err != nil {
-		log.Log.Error(err, "WriteSriovResult(): failed to marshal sriov result", err)
+		log.Log.Error(err, "WriteSriovResult(): failed to marshal sriov result")
 		return err
 	}