Skip to content

Commit

Permalink
envtest: Stick to a specific setup-envtest version
Browse files Browse the repository at this point in the history
Using `@latest` for tools dependecies produces unrepeatable
builds which might break at any point in time. This is
particularly important when maintaining released versions
which need a backport fix.

Note: At the moment is not possible to reference the package
`sigs.k8s.io/controller-runtime/tools/setup-envtest` with a specific
version:

```
go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest
```

See kubernetes-sigs/kubebuilder#2480

Ref:
openshift/sriov-network-operator#849
Signed-off-by: Andrea Panattoni <[email protected]>
  • Loading branch information
zeeke committed Nov 24, 2023
1 parent 6445d38 commit 5cddfbc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ kustomize: ## Download kustomize locally if necessary.

ENVTEST = $(BIN_DIR)/setup-envtest
envtest: ## Download envtest-setup locally if necessary.
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.16)

GOMOCK = $(shell pwd)/bin/mockgen
gomock:
Expand Down

0 comments on commit 5cddfbc

Please sign in to comment.