Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish container images #33

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Mar 12, 2024

Configure GitHub actions to build and publish
container images.

Copy link

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zeeke.
I added couple questions

username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Docker meta

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use official docker meta action instead? https://github.com/docker/metadata-action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

runs-on: ubuntu-20.04
env:
IMAGE_NAME: ghcr.io/${{ github.repository }}
steps:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most actions in this list can be upgrade to a newer v. Do we want to use latest versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. bumped!

@@ -24,6 +24,23 @@ jobs:
GOOS: ${{ matrix.goos }}
run: make build

build-image:
runs-on: ubuntu-20.04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to upgrade OS version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeeke zeeke force-pushed the publish-docker-image branch 2 times, most recently from 03e1a7a to 34f93a7 Compare March 13, 2024 08:24
@ykulazhenkov
Copy link

@zeeke do we want to also build images for different CPU arcs?

@zeeke
Copy link
Member Author

zeeke commented Mar 13, 2024

@zeeke do we want to also build images for different CPU arcs?

Sure, I can add it to the current PR. Adding linux/amd64,linux/arm64,linux/ppc64le as per:

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some a small comment

@zeeke zeeke force-pushed the publish-docker-image branch from d4daf15 to 681d4ac Compare March 13, 2024 10:28
zeeke added 2 commits March 13, 2024 12:00
Configure GitHub actions to build and publish
container images.

Signed-off-by: Andrea Panattoni <[email protected]>
Build and publish images for architectures `linux/amd64,linux/arm64,linux/ppc64le`

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the publish-docker-image branch from 681d4ac to f932467 Compare March 13, 2024 11:02
Copy link

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@SchSeba SchSeba merged commit 14a6aa6 into k8snetworkplumbingwg:master Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants