-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish container images #33
Publish container images #33
Conversation
0017d8c
to
725d19e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zeeke.
I added couple questions
username: ${{ github.repository_owner }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Docker meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use official docker meta action instead? https://github.com/docker/metadata-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
runs-on: ubuntu-20.04 | ||
env: | ||
IMAGE_NAME: ghcr.io/${{ github.repository }} | ||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most actions in this list can be upgrade to a newer v
. Do we want to use latest versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. bumped!
@@ -24,6 +24,23 @@ jobs: | |||
GOOS: ${{ matrix.goos }} | |||
run: make build | |||
|
|||
build-image: | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to upgrade OS version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, picking 22.04, as it's the latest available
https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job#choosing-github-hosted-runners
03e1a7a
to
34f93a7
Compare
@zeeke do we want to also build images for different CPU arcs? |
Sure, I can add it to the current PR. Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some a small comment
d4daf15
to
681d4ac
Compare
Configure GitHub actions to build and publish container images. Signed-off-by: Andrea Panattoni <[email protected]>
Build and publish images for architectures `linux/amd64,linux/arm64,linux/ppc64le` Signed-off-by: Andrea Panattoni <[email protected]>
681d4ac
to
f932467
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Configure GitHub actions to build and publish
container images.