Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow underscores in versions #32

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Allow underscores in versions #32

merged 1 commit into from
Feb 20, 2024

Conversation

ianb-mp
Copy link
Contributor

@ianb-mp ianb-mp commented Feb 20, 2024

Fixes #31

SchSeba
SchSeba approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@Eoghan1232 Eoghan1232 merged commit 3c83f06 into k8snetworkplumbingwg:master Feb 20, 2024
6 checks passed
@ianb-mp ianb-mp deleted the version branch February 20, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

@SchSeba SchSeba SchSeba approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

malformed version
4 participants
@ianb-mp @zeeke @SchSeba @Eoghan1232