Refactor and updates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SchSeba PTAL :) |
nhennigan
approved these changes
Jan 24, 2023
Eoghan1232
pushed a commit
to Eoghan1232/sriov-network-metrics-exporter
that referenced
this pull request
Jan 31, 2023
|
@SchSeba PTAL :) |
walshric
reviewed
Jan 31, 2023
SchSeba
reviewed
Feb 5, 2023
README.md
Outdated
| @@ -6,11 +6,14 @@ The SR-IOV Network Metrics Exporter is designed with the Kubernetes SR-IOV stack | |||
| **This software is a pre-production alpha version and should not be deployed to production servers.** | |||
|
|
|||
| ## Hardware support | |||
| The default netlink implementation for Virtual Function telemetry relies on driver support and a kernel version of 4.4 or higher. This version requires i40e driver of 2.11+ for Intel® 700 series NICs. Updated i40e drivers can be fould at the [Intel Download Center](https://downloadcenter.intel.com/download/24411/Intel-Network-Adapter-Driver-for-PCIe-40-Gigabit-Ethernet-Network-Connections-under-Linux-?v=t) | |||
| The sysfs collector for Virtual Function telemetry supports NICs with drivers that implement the SR-IOV sysfs management interface e.g. i40e, mlnx_en and mlnx_ofed. | |||
There was a problem hiding this comment.
can you change the mlx to mlx5_core
There was a problem hiding this comment.
do you mean change mlnx_en and mlnx_ofed to mlx5_core?
| if !isNetDevice(devClassFilePath) { | ||
| return false | ||
| // getSriovDevAddrs returns the PCI addresses of the SRIOV capable Physical Functions on the host. | ||
| func getSriovDevAddrs() []string { |
There was a problem hiding this comment.
can we reuse functions from the sriov-device-plugin maybe here?
There was a problem hiding this comment.
I believe so, I think a future refactor?
- Update README - Update to go1.18 - Update to k8s v1.25.5 - Reworked vfstats collector - Implemented endpoint unit tests - Add netlink support detection - Add image building to Makefile - Remove deprecated references - Add Mellanox driver to drivers DB - Refactor code to enable testing - Support for NFD SR-IOV feature label - Changes to ensure more uniform Makefile - Implemented initial unit tests - Implemented vfstats package unit tests Co-Authored-By: Eoghan1232 <[email protected]> Co-Authored-By: eoghanlawless <[email protected]> Co-Authored-By: Ipawlikx <[email protected]> Co-Authored-By: nhennigan <[email protected]>
added 4 commits
February 24, 2023 14:41
|
@SchSeba PTAL :) coveralls was removed from action for now, and I will introduce it again in a later PR. |
nhennigan
approved these changes
Feb 27, 2023
Closed
|
@SchSeba if you have time to take a look :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signed off: [email protected] & [email protected]