Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: add support for other linters #15

Merged
merged 1 commit into from
Mar 19, 2020
Merged

lint: add support for other linters #15

merged 1 commit into from
Mar 19, 2020

Conversation

moshe010
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Mar 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 21

  • 2 of 6 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 53.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/rdma/main.go 1 5 20.0%
Totals Coverage Status
Change from base Build 58: -0.2%
Covered Lines: 170
Relevant Lines: 318
💛 - Coveralls

@moshe010 moshe010 requested a review from adrianchiris March 17, 2020 20:37
adrianchiris
adrianchiris reviewed Mar 17, 2020
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
pkg/utils/utils.go Show resolved Hide resolved
cmd/rdma/main_test.go Show resolved Hide resolved
cmd/rdma/main_test.go Outdated Show resolved Hide resolved
cmd/rdma/main_test.go Outdated Show resolved Hide resolved
@adrianchiris
Copy link
Collaborator

just need to fix the small comments and im LGTM

@adrianchiris adrianchiris merged commit d877f9b into k8snetworkplumbingwg:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moshe010 @coveralls @adrianchiris