-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ovsdb.GetOvsPortForContIface should not return error if iface not found #305
fix: ovsdb.GetOvsPortForContIface should not return error if iface not found #305
Conversation
Currently the function returns '"",false, err' in case if interface not found. The signature and usage of this function assume that the function should not return and error in case if interface not found. Fix the function to return '"", false, nil' in case if the interface not found. This change fixes CmdDel for scenario when CmdDel is called after failed CmdAdd or when port was manually removed from the ovs. Signed-off-by: Yury Kulazhenkov <[email protected]>
Hi @ykulazhenkov. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, ykulazhenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Currently, the function returns
"", false, err
if the interface is not found.The function's signature and usage assume that the function should not return an error if the interface is not found.
ovs-cni/pkg/plugin/plugin.go
Line 315 in 7434914
Fix the function to return
"", false, nil
if the interface is not found.This change fixes CmdDel for the scenario when It is called after a failed CmdAdd or when the port is manually removed from the ovs.
Special notes for your reviewer:
Release note:
cc @SchSeba @e0ne