Cleanup ports after IPAM failure #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Horáček <[email protected]>
While most of the configuration gets cleaned up on ADD failure through the removal of containers netns, OVS ports do not. In case port attachment succeeded but the following IPAM configuration failed, we end up with the port left behind. With this patch, the port gets explicitly deleted on IPAM failure. Signed-off-by: Petr Horáček <[email protected]>
kubevirt-bot
added
release-note
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While most of the configuration gets cleaned up on ADD failure through
the removal of containers netns, OVS ports do not.
In case port attachment succeeded but the following IPAM configuration
failed, we end up with the port left behind.
With this patch, the port gets explicitly deleted on IPAM failure.
This fixes #258
Release note: