Add constraints to pod spec #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kennelly <[email protected]>
Signed-off-by: Martin Kennelly <[email protected]>
Containers without memory limits are more likely to be terminated when the node runs out of memory. Containers without cpu limits can exceed the capacity of the node, and affect availability /performance of the host and other containers. Signed-off-by: Martin Kennelly <[email protected]>
Signed-off-by: Kennelly, Martin <[email protected]>
zshi-redhat
reviewed
Apr 8, 2021
| securityContext: | ||
| runAsUser: 10000 | ||
| runAsGroup: 10000 | ||
| runAsNonRoot: true |
There was a problem hiding this comment.
Does runAsNonRoot require setting nonRoot user in Dockerfile?
There was a problem hiding this comment.
@zshi-redhat Unfortunately, it seems that it does for NRI. I tried to remove both of the runAsUser and runAsGroup and I got the following error:
Error: container has runAsNonRoot and image will run as root
There was a problem hiding this comment.
@martinkennelly IIUC, we need to update Dockerfile to use non-root user, right?
If yes, would you mind updating the Dockerfile in this PR?
There was a problem hiding this comment.
@zshi-redhat Good idea. I tried it but it failed with k8 validation:
container has runAsNonRoot and image has non-numeric user (%s), cannot verify user is non-root
See the runAsNonRoot validate here: https://github.com/kubernetes/kubernetes/blob/5648200571889140ad246feb82c8f80a5946f167/pkg/kubelet/kuberuntime/security_context.go#L91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to pod spec to improve security
See commits.
I wanted to group
allowPrivilegeEscalation&readOnlyRootFilesystemat the "pod level"securityContext(ln 23) but it will not allow me.