Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DeviceInfo spec to 1.1.0 #49

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Update DeviceInfo spec to 1.1.0 #49

merged 1 commit into from
Dec 2, 2022

Conversation

ykulazhenkov
Copy link
Contributor

Add "representor-device" field to support DeviceInfo format 1.1.0.

PR in DeviceInfoSpec repo k8snetworkplumbingwg/device-info-spec#3

@ykulazhenkov ykulazhenkov force-pushed the pci-vf-rep branch 3 times, most recently from 69cd588 to 949000b Compare November 30, 2022 08:27
@ykulazhenkov ykulazhenkov marked this pull request as ready for review November 30, 2022 08:31
@ykulazhenkov
Copy link
Contributor Author

cc @adrianchiris

@ykulazhenkov
Copy link
Contributor Author

@amorenoz Could you please take a look at this PR?

maiqueb
maiqueb suggested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a unit test should be added to

network-attachment-definition-client/pkg/utils/net-attach-def_test.go

Line 142 in 9679314

When("DeviceInfo is used as an attribute", func() {
.

@ykulazhenkov
Copy link
Contributor Author

I think a unit test should be added to

network-attachment-definition-client/pkg/utils/net-attach-def_test.go

Line 142 in 9679314

When("DeviceInfo is used as an attribute", func() {

.

I updated spec version in the test and added validation for the new field

@ykulazhenkov ykulazhenkov requested a review from maiqueb December 2, 2022 07:45
maiqueb
maiqueb approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@phoracek phoracek merged commit 6beb26a into k8snetworkplumbingwg:master Dec 2, 2022
This was referenced Dec 5, 2022
Closed
Merged
@adrianchiris adrianchiris mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykulazhenkov @adrianchiris @maiqueb @phoracek