Add multiarch image build support using github actions. #267
Conversation
|
@ashokpariya0 would you please rebase ? |
ashokpariya0
force-pushed
the
add-multiarch-build-support
branch
from
4080153 to
883a54a
Compare
Done. |
images/Dockerfile
Outdated
|
|
||
| FROM registry.access.redhat.com/ubi8/ubi-minimal | ||
| FROM --platform=linux/${TARGETARCH} registry.access.redhat.com/ubi8/ubi-minimal AS final |
There was a problem hiding this comment.
nit: AS final isn't used as ref, imho better to drop it, in case someone theoretically adds another layer
There was a problem hiding this comment.
nit:
AS finalisn't used as ref, imho better to drop it, in case someone theoretically adds another layer
Done.
These changes enable the building of the Multus Dynamic CNI image for multiple platforms (amd64, arm64, s390x) from a single Dockerfile Signed-off-by: Ashok Pariya <[email protected]>
ashokpariya0
force-pushed
the
add-multiarch-build-support
branch
from
883a54a to
a8e9324
Compare
|
Thanks |
here you go, freshly baked: https://github.com/k8snetworkplumbingwg/multus-dynamic-networks-controller/releases/tag/v0.3.5 |
Awesome! I verified the latest release image on s390x, and it worked perfectly! :) |
These changes enable the building of the Multus Dynamic CNI image for multiple platforms (amd64, arm64, s390x) using github actions.
What this PR does / why we need it:
The upstream image of the Multus Dynamic Networks Controller CNI (link) currently supports only the amd64 architecture. These changes extend multi-platform support to include arm64 and s390x architectures, enhancing the compatibility of the Multus Dynamic Networks Controller image across a broader range of systems.
Cross-compilation is performed in the builder image using the TARGETOS and TARGETARCH build arguments, which specify the target OS and architecture. These arguments are automatically configured by the multi-architecture build process using docker buildx
More information: [Docker Buildx Documentation](https://docs.docker.com/build/building/multi-platform/)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #264
Special notes for your reviewer (optional):