Fix CONTAINER_ID with PodSandboxID #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
force-pushed
the
sandboxid
branch
3 times, most recently
from
1fc8523 to
1baa88b
Compare
|
@LionelJouin could you please keep the vendoring changes in an isolated commit ? the github UI doesn't handle well all the changes in this PR (and I'd say 98% of it is on the vendor folder)... That'd help me :) |
|
Done |
maiqueb
requested changes
Mar 25, 2024
Fixes k8snetworkplumbingwg#209 ADD and DEL were called with the ID of the first container found in the pod spec while the PodSandboxID was required. Refactoring has been done to remove the CRI-O and Containerd communication. Instead, only the CRI API is used.
Use of Pod UID instead of Name/Namespace to get the podSandBoxId and NetNs with the CRI API. Using Pod/Namespace might not be unique if a pod is deleted/created, UID will be unique.
|
I removed crio from the yaml file in the second commit |
maiqueb
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ADD and DEL were called with the ID of the first container found in the pod spec while the PodSandboxID was required.
Refactoring has been done to remove the CRI-O and Containerd communication. Instead, only the CRI API is used.
Which issue(s) this PR fixes:
Fixes #209
Special notes for your reviewer (optional):
E2e for CRI-O and Containerd are still needed, and e2e with a CNI that uses CONTAINER_ID might also be needed.