Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test add remove same op #169

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Oct 4, 2023

What this PR does / why we need it:
Add an e2e test asserting this new desired behavior (add and remove attachments in the same operation).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):
I'm also adjusting the timeouts in this PR, since locally this consistently passes.

@maiqueb maiqueb requested a review from kmabda October 4, 2023 15:16
@maiqueb maiqueb merged commit 4443ade into main Oct 5, 2023
@maiqueb maiqueb deleted the add-e2e-test-add-remove-same-op branch October 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants