Controllers test #29
Merged
Controllers test #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#30 should fix CI issue |
Current check for len has no real value. return true upon success. Signed-off-by: Adrian Chiris <[email protected]>
This commit reworks controllers unit tests - split to its own test package and trigger public methods only - modify test logic to spin up informers using fake clientset - add additional tests Signed-off-by: Adrian Chiris <[email protected]>
adrianchiris
force-pushed
the
controllers-test
branch
from
4dd8a50 to
b5aa360
Compare
rollandf
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.