Add server #10
Add server #10
Conversation
|
Note: last 4 commits are relevant (rest will be removed when rebase) |
|
LGTM |
adrianchiris
force-pushed
the
add-server
branch
2 times, most recently
from
de22a97 to
fbdf50d
Compare
pkg/utils/utils.go
Outdated
| if err != nil { | ||
| return "", fmt.Errorf("couldn't determine hostname: %v", err) | ||
| } | ||
| hostName = nodeName |
There was a problem hiding this comment.
why do you need the nodeName?
you can just
hostName , err := os.Hostname() and remove Line 33
There was a problem hiding this comment.
That would define a new hostName var in the inner scope (because of the :=)
i could do:
if len(hostName) == 0 {
var err
hostName, err = os.Hostname
....
}
...
it would save on temp var.
|
General Q: Do we have/need clean-up logic to remove TC rules on POD removal? |
add simple util method to return hostname Signed-off-by: Adrian Chiris <[email protected]>
Its tricky, since you need to be careful the VF is not re-allocated while deleting filters. (so you cannot do it during delete callback in server although operation is fairly short) currently TC rules are aligned for all pods scheduled on node during sync loop. to delete filters for interfaces that were allocated in the past and are not allocated at sync time we could maintain another map of deleted pods then process those first. |
options stores Server option. user facing options are exposed via flags Signed-off-by: Adrian Chiris <[email protected]>
Server is the top level construct that ties various components together. It initializes informers and registers handlers for the various objects. keeping track of changes of the various objects as well as the current state of the cluster WRT the tracked objects. Main business logic is implemented in SyncMultiPolicy method. which is invoked in a rate limited manner to sync TC rules for representors currently associated with pod interfaces scheduled on the current node Signed-off-by: Adrian Chiris <[email protected]>
Run `go mod tidy` to update dependencies Signed-off-by: Adrian Chiris <[email protected]>
No description provided.