Initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe010
reviewed
Jul 10, 2022
.gitignore
Outdated
| e2e/bin/ | ||
|
|
||
| # binary at the top | ||
| /multi-networkpolicy-iptables |
There was a problem hiding this comment.
please update to the right binary file
There was a problem hiding this comment.
It seems unneeded. Makefile will output to build directory.
There was a problem hiding this comment.
will remove altogether
deploy/deploy.yaml
Outdated
| securityContext: | ||
| privileged: true | ||
| capabilities: | ||
| add: ["SYS_ADMIN", "SYS_NET_ADMIN"] |
There was a problem hiding this comment.
why you need capabilities if it privlieged ?
There was a problem hiding this comment.
also i think we would want to avoid privileged.
will just add NET_ADMIN cap (and remove privileged) as it seems to be enough.
adrianchiris
force-pushed
the
initial-commit
branch
2 times, most recently
from
33ea8b5 to
a97c8a5
Compare
moshe010
reviewed
Jul 11, 2022
deploy/deploy.yaml
Outdated
| cpu: "200m" | ||
| memory: "300Mi" | ||
| securityContext: | ||
| privileged: true |
There was a problem hiding this comment.
you still keep the privileged ?
There was a problem hiding this comment.
appologies, with all the PRs and rebases this must have slipped. will update now
- Add basic daemon implementation that sets up signal handling and does nothing - Add Makefile with basic targets to build, build image, run test, deploy and undeploy. - Add Dockerfile to build daemon image including multi-stage build to support building updated iproute2 package for updated TC userspace functionality as first implementation relies on executing tc shell commands - Initialize go.mod/go.sum - Add signal handling functionality to utils package - Add CONTRIBUTING and OWNERS file Signed-off-by: Adrian Chiris <[email protected]>
adrianchiris
force-pushed
the
initial-commit
branch
from
a97c8a5 to
dc87593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling and does nothing
run test, deploy and undeploy.
multi-stage build to support building updated iproute2
package for updated TC userspace functionality as first
implementation relies on executing tc shell commands
Signed-off-by: Adrian Chiris [email protected]