-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use multi arch supported image for kube-rbac-proxy. #440
feat: use multi arch supported image for kube-rbac-proxy. #440
Conversation
The origin-kube-rbac-proxy image is not compatible with the s390x architecture. This change deploys an image that is multi arch supported. Signed-off-by: Ashok Pariya <[email protected]>
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Thanks Please ref the issue, so Ram can see all the discussion there, because he is the maintainer of KMP |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ashokpariya0 do you need this bumped to CNAO? |
done already thanks |
ACK. |
if KMP uses CNAO then yes for the CNAO image part (but not for itself), if it doesnt then no need |
…plumbingwg#440) The origin-kube-rbac-proxy image is not compatible with the s390x architecture. This change deploys an image that is multi arch supported. Signed-off-by: Ashok Pariya <[email protected]>
The origin-kube-rbac-proxy image is not compatible with the s390x architecture. This change deploys an image that is multi arch supported.
What this PR does / why we need it:
The origin-kube-rbac-proxy image is not compatible with the s390x architecture.
This change deploys an image that is multi arch supported(https://quay.io/repository/brancz/kube-rbac-proxy/manifest/sha256:e6a323504999b2a4d2a6bf94f8580a050378eba0900fd31335cf9df5787d9a9b).
Special notes for your reviewer:
proposed image(https://quay.io/repository/brancz/kube-rbac-proxy/manifest/sha256:e6a323504999b2a4d2a6bf94f8580a050378eba0900fd31335cf9df5787d9a9b) is built from parent repo of https://github.com/openshift/kube-rbac-proxy.
Release note: