Add a cleanup loop for failed vm #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR we have an issue if the vm creation fails because there is an validation error from the virt-api we didn't clean the allocation. This PR introduce a cleanup loop into the system. When we hit the create vm mutating webhook we create the regular allocation but we also configure the vm in a wait map. We have a waiting look the will check if the object is removed from the map and if is not after 3-6 second we assume the object wasn't saved into the etcd (no controller event) so we release the object.
|
should fix #37 |
|
we should use a persistent storage for this because the kubemacpool can stop after the mutating webhook but before the controller ack on the request. |
phoracek
requested changes
Jul 3, 2019
| delete(p.vmCreationWaiting, vmName) | ||
| } | ||
|
|
||
| // This function check if there are virtual machines that hits the create |
| @@ -96,5 +96,6 @@ func (r *ReconcilePolicy) Reconcile(request reconcile.Request) (reconcile.Result | |||
| return reconcile.Result{}, err | |||
| } | |||
|
|
|||
| r.poolManager.MarkVMAsReady(fmt.Sprintf("%s/%s", request.Namespace, request.Name)) | |||
There was a problem hiding this comment.
maybe it would be nicer to pass namespace and name as arguments and join them inside the function
| @@ -82,6 +83,7 @@ func (p *PoolManager) AllocateVirtualMachineMac(virtualMachine *kubevirt.Virtual | |||
| } | |||
|
|
|||
| virtualMachine.Spec.Template.Spec.Domain.Devices.Interfaces = copyVM.Spec.Template.Spec.Domain.Devices.Interfaces | |||
| p.vmCreationWaiting[vmNamespaced(virtualMachine)] = 0 | |||
There was a problem hiding this comment.
maybe map[string]bool would look better, so you do p.vmCreationWaiting[...] = true, makes more sense IMO. But even better would be to have a helper function
| @@ -113,6 +115,7 @@ func (p *PoolManager) ReleaseVirtualMachineMac(virtualMachineName string) error | |||
| } | |||
|
|
|||
| delete(p.vmToMacPoolMap, virtualMachineName) | |||
| delete(p.vmCreationWaiting, virtualMachineName) | |||
There was a problem hiding this comment.
can't you use MarkVMAsReady function?
|
replaced by #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we have an issue if the vm creation fails because there
is an validation error from the virt-api we didn't clean the allocation.
This PR introduce a cleanup loop into the system.
When we hit the create vm mutating webhook we create the regular
allocation but we also configure the vm in a wait map.
We have a waiting look the will check if the object is removed from the
map and if is not after 3-6 second we assume the object wasn't saved
into the etcd (no controller event) so we release the object.