code-gen: provide types and generator scripts #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
add-crd-clients-listers-informers
branch
14 times, most recently
from
fc09fdf to
a5b62a2
Compare
maiqueb
commented
Aug 28, 2023
maiqueb
commented
Aug 28, 2023
| @@ -0,0 +1,55 @@ | |||
| module github.com/maiqueb/persistentips | |||
There was a problem hiding this comment.
my plan is to keep this in a personal repo, then "donate" the CRD to the k8snetworkplumbingwg.
Plus push an update proposal to the kubernetes multi network de-facto standard.
qinqon
requested changes
Aug 28, 2023
|
Can you amend please the commits with the commands used to generate stuff ? |
maiqueb
force-pushed
the
add-crd-clients-listers-informers
branch
3 times, most recently
from
86750e0 to
59900fd
Compare
qinqon
requested changes
Aug 30, 2023
maiqueb
force-pushed
the
add-crd-clients-listers-informers
branch
from
59900fd to
4dea445
Compare
phoracek
reviewed
Aug 31, 2023
maiqueb
force-pushed
the
add-crd-clients-listers-informers
branch
from
4dea445 to
7f98396
Compare
Also provide a minimal github workflow to build the code. Signed-off-by: Miguel Duarte Barroso <[email protected]>
To run the code generators, the user should execute the `hack/update-codegen.sh` script. The generated code will be located in `pkg/crd/persistentip/v1alpha1/github.com`. Then, it must be copied to the correct place: ``` cp -r \ pkg/crd/persistentip/v1alpha1/github.com/maiqueb/persistentips/pkg/crd/persistentip/v1alpha1/apis/* \ pkg/crd/persistentip/v1alpha1/ ``` Signed-off-by: Miguel Duarte Barroso <[email protected]>
Keeping the vendor commit isolated helps during code review, since there are a lot less files - meaning the github web UI will have less to render. Please review commit by commit. Signed-off-by: Miguel Duarte Barroso <[email protected]>
The binary should be compiled using the following command: ``` go build -o _out/persistentips_dummy_client cmd/example/main.go ``` Then executed via: ``` _out/persistentips_dummy_client --kubeconfig ~/.kube/config ``` Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
commented
Aug 31, 2023
qinqon
approved these changes
Aug 31, 2023
maiqueb
force-pushed
the
add-crd-clients-listers-informers
branch
from
7f98396 to
5b2946c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide a minimal github workflow to build the code.
At this stage, what I'm most looking for is:
PersistentIP/PersistentIPs/PersistentIPAMAllocation/IPAMAllocationw/ a persistent flag ? ....