feat: cilium integration support #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimishamehta5
changed the title
nimishamehta5
force-pushed
the
cilium-int
branch
2 times, most recently
from
4ff0678
to
dae02e2
Compare
Signed-off-by: Nimisha Mehta [email protected]
nimishamehta5
force-pushed
the
cilium-int
branch
from
dae02e2
to
3e829a9
Compare
|
Closing since this needs restructuring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1238
📑 Description
Adds support for Cilium. Implements basic checks on usual Cilium daemonsets and deployments.
Ideally, we don't want to re-implement the huge number of checks Cilium already does, so I wanted to just read the
cilium status -o jsonoutput if the user has Cilium CLI installed, and collect the errors from that report. But the errors are lost when reading the report JSON format.I filed a fix in cilium for that here: cilium/cilium#34654
It is not reasonable to expect everyone to have the most updated version of the CLI even once this is released though, so we have to implement some checks ourselves.
✅ Checks
ℹ Additional Information