feat: skip k3s node type EtcdIsVoter
#1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuHyung-Son
reviewed
Jun 30, 2024
yankay
force-pushed
the
skip-k3s-node-type
branch
from
52560c3 to
991dd31
Compare
Yes, it's only for k3s |
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
skip-k3s-node-type
branch
from
991dd31 to
2eb9346
Compare
JuHyung-Son
reviewed
Jul 3, 2024
|
I am inclined to agree that if this unblocks errors in k3s then we should add it. Anyone else @k8sgpt-ai/k8sgpt-maintainers ? |
|
no objections from my side, looks safe :) @AlexsJones |
ronaldpetty
pushed a commit
to ronaldpetty/k8sgpt
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Kay Yan <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Ronald Petty <[email protected]>
AlexsJones
added a commit
that referenced
this pull request
Jul 18, 2024
* refresh fork Signed-off-by: Ronald Petty <[email protected]> * let out, wasn't sure it was needed, but seems it might be in CI pipeline Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update docker/setup-buildx-action digest to 4fd8129 (#1173) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2 to v2.20.0-20240406062209-1cc152efbf5c.1 (#1147) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.0 (#1146) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module google.golang.org/grpc to v1.64.1 [security] (#1178) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/mittwald/go-helm-client to v0.12.10 (#1177) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * feat: add custom http headers to openai related api backends (#1174) * feat: add custom http headers to openai related api backends Signed-off-by: Aris Boutselis <[email protected]> * ci: add custom headers test Signed-off-by: Aris Boutselis <[email protected]> * add error handling Signed-off-by: Aris Boutselis <[email protected]> * chore(deps): update docker/setup-buildx-action digest to 4fd8129 (#1173) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2 to v2.20.0-20240406062209-1cc152efbf5c.1 (#1147) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.0 (#1146) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Aris Boutselis <[email protected]> * Update README.md Signed-off-by: Aris Boutselis <[email protected]> --------- Signed-off-by: Aris Boutselis <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * chore(main): release 0.3.38 (#1165) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.1 (#1179) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update actions/setup-go digest to 0a12ed9 (#1182) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * ci: release to krew index as kubectl-gpt (#1100) Signed-off-by: Miguel Varela Ramos <[email protected]> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update k8s.io/utils digest to 18e509b (#1183) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/prometheus/prometheus to v0.53.1 (#1035) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/ibm/watsonx-go to v1.0.1 (#1187) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * feat: skip k3s node type EtcdIsVoter (#1167) Signed-off-by: Kay Yan <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * feat: fix the custom-analysis printing (#1195) Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): pin goreleaser/goreleaser-action action to 286f3b1 (#1171) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc/go to v1.4.0-20240715142657-3785f0a44aae.2 (#1196) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update actions/upload-artifact digest to 0b2256b (#1175) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * Update pkg/integration/kyverno/kyverno.go lgtm Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * remove unused function Signed-off-by: Ronald Petty <[email protected]> --------- Signed-off-by: Ronald Petty <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> Signed-off-by: Miguel Varela Ramos <[email protected]> Signed-off-by: Kay Yan <[email protected]> Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Miguel Varela Ramos <[email protected]> Co-authored-by: Kay Yan <[email protected]> Co-authored-by: Alex Jones <[email protected]>
10 tasks
AlexsJones
pushed a commit
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Kay Yan <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: AlexsJones <[email protected]>
AlexsJones
added a commit
that referenced
this pull request
Oct 24, 2024
* refresh fork Signed-off-by: Ronald Petty <[email protected]> * let out, wasn't sure it was needed, but seems it might be in CI pipeline Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update docker/setup-buildx-action digest to 4fd8129 (#1173) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2 to v2.20.0-20240406062209-1cc152efbf5c.1 (#1147) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.0 (#1146) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module google.golang.org/grpc to v1.64.1 [security] (#1178) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/mittwald/go-helm-client to v0.12.10 (#1177) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * feat: add custom http headers to openai related api backends (#1174) * feat: add custom http headers to openai related api backends Signed-off-by: Aris Boutselis <[email protected]> * ci: add custom headers test Signed-off-by: Aris Boutselis <[email protected]> * add error handling Signed-off-by: Aris Boutselis <[email protected]> * chore(deps): update docker/setup-buildx-action digest to 4fd8129 (#1173) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2 to v2.20.0-20240406062209-1cc152efbf5c.1 (#1147) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.0 (#1146) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Aris Boutselis <[email protected]> * Update README.md Signed-off-by: Aris Boutselis <[email protected]> --------- Signed-off-by: Aris Boutselis <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * chore(main): release 0.3.38 (#1165) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update anchore/sbom-action action to v0.16.1 (#1179) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update actions/setup-go digest to 0a12ed9 (#1182) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * ci: release to krew index as kubectl-gpt (#1100) Signed-off-by: Miguel Varela Ramos <[email protected]> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update k8s.io/utils digest to 18e509b (#1183) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/prometheus/prometheus to v0.53.1 (#1035) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module github.com/ibm/watsonx-go to v1.0.1 (#1187) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * feat: skip k3s node type EtcdIsVoter (#1167) Signed-off-by: Kay Yan <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * feat: fix the custom-analysis printing (#1195) Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): pin goreleaser/goreleaser-action action to 286f3b1 (#1171) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * fix(deps): update module buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc/go to v1.4.0-20240715142657-3785f0a44aae.2 (#1196) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * chore(deps): update actions/upload-artifact digest to 0b2256b (#1175) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ronald Petty <[email protected]> * Update pkg/integration/kyverno/kyverno.go lgtm Co-authored-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> Signed-off-by: Ronald Petty <[email protected]> * remove unused function Signed-off-by: Ronald Petty <[email protected]> --------- Signed-off-by: Ronald Petty <[email protected]> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Aris Boutselis <[email protected]> Signed-off-by: Miguel Varela Ramos <[email protected]> Signed-off-by: Kay Yan <[email protected]> Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Ronald Petty <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Miguel Varela Ramos <[email protected]> Co-authored-by: Kay Yan <[email protected]> Co-authored-by: Alex Jones <[email protected]> Signed-off-by: AlexsJones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1166
📑 Description
Skip k3s node Condition EtcdIsVoter Status reported as an error.
✅ Checks
ℹ Additional Information