Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[dendrite] Upgrade app version and change default value to Github Containers #1743

Merged
merged 4 commits into from
Aug 18, 2022
Merged

[dendrite] Upgrade app version and change default value to Github Containers #1743

merged 4 commits into from
Aug 18, 2022

Conversation

samip5
Copy link
Contributor

@samip5 samip5 commented Aug 12, 2022 •
edited
Loading

Description of the change

Upgraded app version to 0.9.3 and changed to use ghcr.io.

Benefits

Will not hit Docker Hub rate limits and newer software.

Additional information

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

@ghost ghost added size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Aug 12, 2022
wrmilling
wrmilling suggested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@wrmilling wrmilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized you had this PR open, I am going to close mine (#1752) in favor of these updates. Also, the docker image should be at v0.9.3 now.

charts/incubator/dendrite/Chart.yaml Outdated Show resolved Hide resolved
charts/incubator/dendrite/Chart.yaml Outdated Show resolved Hide resolved
@wrmilling wrmilling mentioned this pull request Aug 18, 2022
Closed
4 tasks
samip5 and others added 2 commits August 18, 2022 20:18
@samip5 samip5 requested review from wrmilling and removed request for onedr0p, carpenike, bjw-s, billimek and truxnell August 18, 2022 17:19
@ghost ghost added changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:failed CI status: install failed install:ok CI status: install successful and removed changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:ok CI status: install successful install:failed CI status: install failed labels Aug 18, 2022
wrmilling
wrmilling approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@wrmilling wrmilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Already tested the ghcr change on my install.

@onedr0p onedr0p merged commit 7f68a48 into k8s-at-home:master Aug 18, 2022
@samip5 samip5 deleted the patch-3 branch August 18, 2022 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wrmilling wrmilling wrmilling approved these changes

@onedr0p onedr0p onedr0p approved these changes

Assignees
No one assigned
Labels
changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/XS Categorises a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samip5 @onedr0p @wrmilling