Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[homer]: update app version, switch to security context #1726

Merged
merged 5 commits into from
Aug 1, 2022
Merged

[homer]: update app version, switch to security context #1726

merged 5 commits into from
Aug 1, 2022

Conversation

pascaliske
Copy link
Contributor

@pascaliske pascaliske commented Aug 1, 2022 •
edited
Loading

Signed-off-by: Pascal Iske [email protected]

Description of the change

  • Updated app version to v22.07.2
  • The environment variables for asset permissions were removed and a security context object were configured for the correct file permissions of the apps assets.

Benefits

The code change allows the usage with newer app versions than 22.02.2, e.g. v22.06.1 and newer.

Possible drawbacks

Custom values of users need to switch from env variables to security context as well.

Applicable issues

Additional information

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

@ghost ghost added the size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2022
@ghost ghost added size/S Categorises a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Categorises a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2022
@pascaliske pascaliske marked this pull request as ready for review August 1, 2022 08:57
@pascaliske pascaliske mentioned this pull request Aug 1, 2022
Closed
bjw-s
bjw-s suggested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@bjw-s bjw-s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR! Just a small change to the values requested before we can merge, but looks good otherwise 👍 (assuming the CI passes 😉 )

charts/stable/homer/values.yaml Outdated Show resolved Hide resolved
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:ok CI status: changelog validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Aug 1, 2022
@pascaliske pascaliske requested a review from bjw-s August 1, 2022 18:11
@bjw-s bjw-s enabled auto-merge (squash) August 1, 2022 19:45
@bjw-s bjw-s merged commit 526a6c7 into k8s-at-home:master Aug 1, 2022
@pascaliske pascaliske deleted the feature/update-homer-chart branch August 2, 2022 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bjw-s bjw-s bjw-s approved these changes

@onedr0p onedr0p Awaiting requested review from onedr0p onedr0p is a code owner

@billimek billimek Awaiting requested review from billimek billimek is a code owner

@carpenike carpenike Awaiting requested review from carpenike carpenike is a code owner

@truxnell truxnell Awaiting requested review from truxnell truxnell is a code owner

Assignees
No one assigned
Labels
changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/S Categorises a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Homer] Support for the latest app version
2 participants
@pascaliske @bjw-s