Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[ghost] Add new chart #1309

Merged
merged 6 commits into from
Dec 14, 2021
Merged

[ghost] Add new chart #1309

merged 6 commits into from
Dec 14, 2021

Conversation

samip5
Copy link
Contributor

@samip5 samip5 commented Dec 13, 2021

Description of the change

Add new Chart for Ghost

Benefits

Able to deploy Ghost easilly

Possible drawbacks

The configuration of it, is far from optimal.

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

Signed-off-by: Skyler Mäntysaari <[email protected]>
@ghost ghost added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:failed CI status: install failed labels Dec 13, 2021
Copy link
Contributor

@bjw-s bjw-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR! 🏅 I've left a few comments / questions.

charts/stable/ghost/README_CHANGELOG.md.gotmpl Outdated Show resolved Hide resolved
charts/stable/ghost/values.yaml Show resolved Hide resolved
charts/stable/ghost/values.yaml Show resolved Hide resolved
charts/stable/ghost/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Skyler Mäntysaari <[email protected]>
Signed-off-by: Skyler Mäntysaari <[email protected]>
Signed-off-by: Skyler Mäntysaari <[email protected]>
@samip5
Copy link
Contributor Author

samip5 commented Dec 13, 2021

@bjw-s Could you try the CI again?

@bjw-s bjw-s linked an issue Dec 13, 2021 that may be closed by this pull request
@carpenike carpenike closed this Dec 13, 2021
@carpenike carpenike reopened this Dec 13, 2021
@carpenike
Copy link
Member

Closed and reopened, CI should kick off again.

@bjw-s
Copy link
Contributor

bjw-s commented Dec 13, 2021

I forgot to reply that I approved the CI 😅 Looking at the logs, it seems like it is somehow trying to run with sqlite in the CI.

@samip5
Copy link
Contributor Author

samip5 commented Dec 13, 2021

I forgot to reply that I approved the CI 😅 Looking at the logs, it seems like it is somehow trying to run with sqlite in the CI.

Yes, because that's what I told it to do. Which apperantly doesn't work tho.

Signed-off-by: Skyler Mäntysaari <[email protected]>
@samip5
Copy link
Contributor Author

samip5 commented Dec 14, 2021

@bjw-s & @carpenike Maybe now the CI will work? I did pretty much the same for it as is done for monica.

@ghost ghost added install:ok CI status: install successful and removed install:failed CI status: install failed labels Dec 14, 2021
@bjw-s
Copy link
Contributor

bjw-s commented Dec 14, 2021

Looks like the CI passed, I'll take a look at the chart in a bit 👍🏻

Copy link
Contributor

@bjw-s bjw-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@bjw-s bjw-s merged commit 2f8d914 into k8s-at-home:master Dec 14, 2021
@bjw-s
Copy link
Contributor

bjw-s commented Dec 14, 2021

@all-contributors Please add @samip5 for code

@allcontributors
Copy link
Contributor

@bjw-s

I've put up a pull request to add @samip5! 🎉

@samip5 samip5 deleted the add-ghost branch January 27, 2022 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost chart
3 participants