Add flag to support ClusterIP exposed CoreDNS #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments (Calico bare-metal, etc) may allow direct client reachability to the Service CIDR, bypassing the need to assign and use LoadBalancerIPs. A new config flag and environment variable allows selection/return of the ClusterIPs in the assistant rather than externally assigned LoadBalancer IPs. Signed-off-by: Brandon Ewing <[email protected]>
bewing
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev,
jkremser and
abaguas
as code owners
abaguas
reviewed
Dec 14, 2024
There was a problem hiding this comment.
We can simplify the configuration to the users by not adding a new flag. Setting the CoreDNSExposed flag to true is enough.
A service only has one type so we dynamically check if the service is of type LoadBalancer or ClusterIP. Then we can extend logic of the CoreDNSExposedIPs function to fetch the IP addresses depending on the type.
| @@ -58,8 +58,7 @@ func NewGslbAssistant(client client.Client, k8gbNamespace string, edgeDNSServers | |||
| } | |||
| } | |||
|
|
|||
| // CoreDNSExposedIPs retrieves list of IP's exposed by CoreDNS | |||
| func (r *Gslb) CoreDNSExposedIPs() ([]string, error) { | |||
| func (r *Gslb) GetCoreDNSService() (*corev1.Service, error) { | |||
There was a problem hiding this comment.
I like this separation of responsibilities. One function to fetch the service and another one to fetch the IP address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments (Calico bare-metal, etc) may allow direct client reachability to the Service CIDR, bypassing the need to assign and use LoadBalancerIPs. A new config flag and environment variable allows selection/return of the ClusterIPs in the assistant rather than externally assigned LoadBalancer IPs.