Rancher Fleet support #1255
Rancher Fleet support #1255
Conversation
kuritka
requested review from
donovanmuller,
k0da,
ytsarev and
jkremser
as code owners
|
Hi @ytsarev, good question: currently we deal with clusterLabels map injected by fleet, which injects its own values into values.yaml before installing the helmchart. # values.yaml
global:
fleet:
clusterLabels:
k8gb: "true"
k8gb-ClusterGeoTag: "us"
k8gb-ExtClusterGeoTags: "eu"
...
k8gb:
image: ...
tag: ...
...In fact, I don't know exactly what else fleet is able to inject in different edge-cases, so I provided it with an object. Outside of this bounded |
|
@ytsarev this is a change to a schema to allow extra values to be added. It doesn't affect helm chart itself, just validation is aware of such case. And enables k8gb to be rollout cross quite huge fleet of the clusters |
|
@ytsarev this is not something user controlls. This is internal usage of those fields. A structure evaluated prior helm call and processes helm values based on this. Take it as internal passthrough storage for particular cluster. without it. Helm just fails to validate values, as schema didn't allow extra values to be passed in. |
|
@k0da the statement that k8gb was tested and helm chart adapted for Rancher fleet setup will be anyway useful for users and for the project |
kuritka
force-pushed
the
fleet-support
branch
from
d4d4448 to
8ef8e6f
Compare
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
👍 |
kuritka
force-pushed
the
fleet-support
branch
from
8ef8e6f to
71a38ef
Compare
There was a problem hiding this comment.
this is great. Can we link this manual in the main README, probably extending https://www.k8gb.io/#installation-and-configuration-tutorials ?
There was a problem hiding this comment.
@ytsarev , fixed, thx.
Rancher fleet installs applications from the existing Helm Chart. During installation it injects at least properties into `global.fleet`. Because k8gb schema is too strict, `helm install` does not work because fleet injects its properties We solved this by deleting the schema and rebuilding Chart. This PR whitelists the fleet object in globals, so k8gb can be installed directly. Signed-off-by: Michal Kuritka <[email protected]>
kuritka
force-pushed
the
fleet-support
branch
from
71a38ef to
dfde856
Compare
Rancher fleet installs applications from the existing Helm Chart. During installation it injects at least properties into
global.fleet. Because k8gb schema is too strict,helm installdoes not work because fleet injects its properties We solved this by deleting the schema and rebuilding Chart.This PR whitelists the fleet object in globals, so k8gb can be installed directly.