-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes the incorrect total items count in a paginated list items q… #271
Conversation
09545b5
to
789af91
Compare
This problem was originally noticed while we were using Kine with a k8s api server. We make a paginated list objects api call and it returned incorrect Please consider merging this or else fix this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I do have one note about read consistency on the count call.
1111c8b
to
3e49adc
Compare
Can also test this with: kubectl proxy &
curl -s 'http://localhost:8001/api/v1/namespaces/kube-system/pods?limit=1&resourceVersion=700&resourceVersionMatch=Exact' On a default k3s cluster shortly after startup, there should be 6 items remaining. |
…uery Signed-off-by: Hemant Singh <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
3e49adc
to
3d37f98
Compare
Thankyou for taking quick action on this and fixing other case as well. Looking forward to get it merged. |
When making a list query the returned total matched items count is wrong.
Steps to replicate:
create some keys in the database with specific prefix say
/registry
then query with limit clause.the count shows wrong value.
After this Fix