Attempt to continue when encountering errors in createDBIfNotExist #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database might already exist even if we encounter errors in createDBIfNotExist, so instead of erroring out, log warnings and attempt to continue. Signed-off-by: Morten Lied Johansen <[email protected]>
brandond
reviewed
Dec 13, 2023
brandond
reviewed
Dec 13, 2023
brandond
requested changes
Dec 13, 2023
brandond
reviewed
Dec 13, 2023
You are entirely right, not sure how I missed that. Serves me right for trying to crank it out just before bedtime 🙂. I'll take another pass over this today if I get the time. |
…ction Signed-off-by: Morten Lied Johansen <[email protected]>
Signed-off-by: Morten Lied Johansen <[email protected]>
|
@brandond I think I'm happy with this now, anything you think should be changed? |
brandond
requested changes
Dec 13, 2023
Co-authored-by: Brad Davidson <[email protected]> Signed-off-by: Morten Lied Johansen <[email protected]>
brandond
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database might already exist even if we encounter errors in createDBIfNotExist, so instead of erroring out, log warnings and attempt to continue.
Fixes k3s-io/k3s#9033