Call wal_checkpoint during startup/compact for sqlite #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
briandowns
approved these changes
Nov 16, 2021
dweomer
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address k3s-io/k3s#3660
As discussed at k3s-io/k3s#4044 (comment), highly active clusters can cause checkpoint starvation due to there always being an active reader. Forcing a checkpoint at the end of compaction should prevent this from occurring, at the cost of blocking writers for a short period. This should not be any worse than the blocking that currently occurs for the compact transaction.
This also adds a WAL truncate at startup, which should shrink the on-disk WAL back down to a reasonable size for users whose files have grown out of control due to the issue described above.
https://sqlite.org/pragma.html#pragma_wal_checkpoint
Signed-off-by: Brad Davidson [email protected]