Don't use zgrep in check-config if apparmor profile is enforced
#7939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
briandowns
approved these changes
Jul 10, 2023
brandond
approved these changes
Jul 11, 2023
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7939 +/- ##
==========================================
+ Coverage 46.95% 51.42% +4.46%
==========================================
Files 143 143
Lines 14560 14564 +4
==========================================
+ Hits 6837 7489 +652
+ Misses 6628 5890 -738
- Partials 1095 1185 +90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 12, 2023
…s-io#7939) * Don't use zgrep if apparmor is enforced for it * Bump e2e se timeouts for reencryption time Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 12, 2023
…s-io#7939) * Don't use zgrep if apparmor is enforced for it * Bump e2e se timeouts for reencryption time Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 12, 2023
…s-io#7939) * Don't use zgrep if apparmor is enforced for it * Bump e2e se timeouts for reencryption time Signed-off-by: Derek Nola <[email protected]>
This was referenced Jul 12, 2023
dereknola
changed the title
check-config if apparmor porfile is enforcedcheck-config if apparmor profile is enforced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
Bypass zgrep on opensuse 15.4+, with an apparmor profile for zgrep due to CVE-2022-1271.
Types of Changes
Verification
E2E_NODE_BOXES="opensuse/Leap-15.4.x86_64" vagrant up server-0 --no-provisionzypper in apparmor-utils apparmor-parser apparmor-profilesaa-enforce zgrepk3s check-configCheck config should pass with no issues
Testing
Linked Issues
#6278
User-Facing Change
Further Comments