Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm-controller version for repo auth/ca support #7525

Merged
merged 1 commit into from
May 10, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented May 10, 2023

Proposed Changes

Bump helm-controller version for repo auth/ca support

Types of Changes

enhancement

Verification

See linked issue, and example in k3s-io/helm-controller#192 (comment)

Testing

Linked Issues

User-Facing Change

The embedded Helm controller now supports authenticating to chart repositories via credentials stored in a Secret, as well as passing repo CAs via ConfigMap.

Further Comments

@brandond brandond requested a review from a team as a code owner May 10, 2023 19:11
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: +27.73 🎉

Comparison is base (b4bc57d) 19.83% compared to head (d5cffc8) 47.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7525       +/-   ##
===========================================
+ Coverage   19.83%   47.57%   +27.73%     
===========================================
  Files          81      140       +59     
  Lines        7621    14284     +6663     
===========================================
+ Hits         1512     6795     +5283     
- Misses       5882     6411      +529     
- Partials      227     1078      +851     
Flag Coverage Δ
inttests 44.92% <12.50%> (?)
unittests 19.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/containerd/main.go 0.00% <0.00%> (ø)
pkg/containerd/utility_linux.go 0.00% <0.00%> (ø)
pkg/server/server.go 56.97% <100.00%> (ø)

... and 112 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants