Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k3s-root for aarch64 page size fix #7364

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 27, 2023

Proposed Changes

Bump k3s-root

Types of Changes

bugfix

Verification

Run k3s on aarch64 with page size != 4k

Testing

Linked Issues

User-Facing Change

K3s once again supports aarch64 nodes with page size > 4k

Further Comments

@brandond brandond requested a review from a team as a code owner April 27, 2023 04:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.48 🎉

Comparison is base (8d0255a) 9.82% compared to head (087bddb) 19.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7364      +/-   ##
==========================================
+ Coverage    9.82%   19.30%   +9.48%     
==========================================
  Files         147       81      -66     
  Lines       10845     5459    -5386     
==========================================
- Hits         1065     1054      -11     
+ Misses       9558     4183    -5375     
  Partials      222      222              
Flag Coverage Δ
unittests 19.30% <0.00%> (+9.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/flannel/setup.go 0.00% <0.00%> (ø)
pkg/authenticator/passwordfile/passwordfile.go 80.64% <ø> (ø)
pkg/cli/cmds/etcd_snapshot.go 0.00% <0.00%> (ø)
pkg/cloudprovider/cloudprovider.go 0.00% <0.00%> (ø)
pkg/daemons/config/types.go 67.21% <ø> (ø)

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hai asahi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants