Fix sonobouy tests on v1.25 #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use --disable instead of --no-deploy, and don't silently succeed if sonobouy never runs Signed-off-by: Brad Davidson <[email protected]>
dereknola
approved these changes
Nov 1, 2022
|
manuelbuil
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Looks like the sonobuoy tests have been failing since we made use of
--no-deployan error. Compounding this was another issue in the test scripts that caused the error to be swallowed if sonobuoy never ran at all.Types of Changes
CI bugfix
Verification
Check CI logs
Testing
yes
Linked Issues
User-Facing Change
Further Comments