Save agent token to /var/lib/rancher/k3s/server/agent-token #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having separate tokens for server and agent nodes is a nice feature. However, passing server's plain `K3S_AGENT_TOKEN` value to `k3s agent --token` without CA hash is insecure when CA is self-signed, and k3s warns about it in the logs: ``` Cluster CA certificate is not trusted by the host CA bundle, but the token does not include a CA hash. Use the full token from the server's node-token file to enable Cluster CA validation. ``` Okay so I need CA hash but where should I get it? This commit attempts to fix this issue by saving agent token value to `agent-token` file with CA hash appended. Signed-off-by: Vladimir Kochnev <[email protected]>
marshall-lee
force-pushed
the
write-agent-token-file
branch
from
bf97c12 to
f1144c7
Compare
brandond
approved these changes
Jul 28, 2022
briandowns
approved these changes
Jul 28, 2022
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Having separate tokens for server and agent nodes is a nice feature.
However, passing server's plain
K3S_AGENT_TOKENvalue tok3s agent --tokenwithout CA hash is insecure when CA is self-signed, and k3s warns about it in the logs:Okay so I need CA hash but where should I get it?
This commit attempts to fix this issue by saving agent token value to
agent-tokenfile with CA hash appended.Types of Changes
New feature
Verification
Testing
Linked Issues
User-Facing Change
Further Comments