Improve flannel code and logging

[manuelbuil]

Signed-off-by: Manuel Buil [email protected]

Proposed Changes

This PR improves flannel code a bit:

• Swaps nodeConfig.FlannelConf to nodeConfig.FlannelConfFile, which describes the content of the variable better
• Adds more logging, especially using the debug option of logrus
• Fixes a bug where createFlannelConf was returning nil even though there was an error

Types of Changes

Bugfix

Verification

Linked Issues

#4549

User-Facing Change

Further Comments

[codecov-commenter]

Codecov Report

Merging #4550 (e3e404a) into master (d93c82f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
- Coverage   12.03%   12.03%   -0.01%     
==========================================
  Files         135      135              
  Lines        9179     9183       +4     
==========================================
  Hits         1105     1105              
- Misses       7838     7842       +4     
  Partials      236      236              

Flag	Coverage Δ
inttests	0.76% <0.00%> (-0.01%)	⬇️
unittests	11.59% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/agent/config/config.go	0.00% <0.00%> (ø)
pkg/agent/flannel/setup.go	0.00% <0.00%> (ø)
pkg/daemons/config/types.go	50.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93c82f...e3e404a. Read the comment docs.

[VestigeJ]

Validated

Awaiting approval from Manuel on this Verification process the logs are quite verbose - apologies especially just passing in $ sudo journalctl | grep flannel reveals quite a lot and traces it back to specific go files IMHO.

Release 1.20

Release 1.21

Release 1.22