-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for an s3 folder when listing objects #3807
Conversation
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3807 +/- ##
==========================================
- Coverage 11.55% 11.54% -0.02%
==========================================
Files 136 136
Lines 8815 8823 +8
==========================================
Hits 1019 1019
- Misses 7575 7583 +8
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Does this currently find everything properly if there's not a prefix specified? I guess it just non-recursively lists everything in the top-level directory (no prefix)? |
Correct. Only looks at the top level (bucket level). |
* account for an s3 folder when listing objects Signed-off-by: Brian Downs <[email protected]>
* account for an s3 folder when listing objects Signed-off-by: Brian Downs <[email protected]>
Proposed Changes
Additional logic needed to be added to account for the use of folders within AWS S3 buckets in the "list snapshots" routine.
Types of Changes
Verification
Run the command below and verify that what is listed in the ConfigMap is what's in the AWS folder.
Linked Issues
User-Facing Change
Further Comments