Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.21] Cannot write data to local PVC #3721

Merged
merged 2 commits into from
Jul 28, 2021
Merged

[Backport 1.21] Cannot write data to local PVC #3721

merged 2 commits into from
Jul 28, 2021

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Jul 28, 2021 •
edited
Loading

  • Fix to allow non-root users to access storage volumes, while still restricting users from finding other volumes they do not own.
  • Removal of integration test, as underlying infrastructure has not been ported to 1.21

Signed-off-by: Derek Nola [email protected]

Linked Issues

#3720
Original Issue: #3704
Original PR: #3714

dereknola added 2 commits July 28, 2021 10:31
@dereknola
Fix to allow non-root users access to storage volumes. (k3s-io#3714)
30a13b6 
* Fix to prevent non-root users from accessing storage directory, while allowing non-root users access to subdirectories.

Signed-off-by: dereknola <[email protected]>

* Added integration test

Signed-off-by: dereknola <[email protected]>
@dereknola
Removed integration tests
613f8a0 
Signed-off-by: dereknola <[email protected]>
@dereknola dereknola self-assigned this Jul 28, 2021
@dereknola dereknola requested a review from a team as a code owner July 28, 2021 17:38
@dereknola dereknola merged commit e6247d5 into k3s-io:release-1.21 Jul 28, 2021
@manics manics mentioned this pull request Aug 1, 2021
Closed
@dereknola dereknola deleted the bp_localstorage_777_1.21 branch August 5, 2021 22:57
@gnoejuan gnoejuan mentioned this pull request Sep 5, 2021
Closed
@iwilltry42 iwilltry42 mentioned this pull request Sep 20, 2021
Closed
@mkesper
Copy link

mkesper commented Oct 13, 2021

Is there any way to include these tests again? This seems to be important behavior that should be checked for correctness.

@al3x609
Copy link

al3x609 commented Apr 25, 2024

I'm using version v1.29.3+k3s1 of k3s, but the issue of read-only persistence volumes for non-root containers still persists.

@cwayne18
Copy link
Member

Please open a new issue with logs and we'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@galal-hussein galal-hussein galal-hussein approved these changes

Assignees

@dereknola dereknola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dereknola @mkesper @al3x609 @cwayne18 @galal-hussein @briandowns