[release-1.21] Add events to deploy controller #3615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
kubectl get events -n kube-system
orkubectl describe addon -n kube-system <addon>
. Events are inspired by k/k event behavior for Pods, where Events are created for container pull start, container pull success/failure, etc. They should be meaningful but not spammy.Types of changes
Verification
Note events when describing AddOn: kubectl describe addon -n kube-system coredns`
Linked Issues
This is a stripped-down version of #2169 that only adds events; it doesn't attempt to address any of the other issues with tracking who modified the resource, since this can be (minimally) accomplished with #3433
Example output