Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skew semver for release-XX branches #11531

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Release-1.32 tests now skip as intended
  • Semver for older release branches now correct finds previous version

Types of Changes

Test fix

Verification

Tests pass when run manually with older branches

Testing

Linked Issues

Seen in https://github.com/k3s-io/k3s/actions/runs/12643149990/job/35264904033

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner January 7, 2025 17:48
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (e64e2fc) to head (58b9d45).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e64e2fc) and HEAD (58b9d45). Click for more details.

HEAD has 12 uploads less than BASE
Flag BASE (e64e2fc) HEAD (58b9d45)
unittests 1 0
inttests 11 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11531      +/-   ##
==========================================
- Coverage   43.85%   35.76%   -8.10%     
==========================================
  Files         181      164      -17     
  Lines       18809    18333     -476     
==========================================
- Hits         8249     6557    -1692     
- Misses       9351    10718    +1367     
+ Partials     1209     1058     -151     
Flag Coverage Δ
e2etests 35.76% <ø> (-0.03%) ⬇️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 67ffd2a into k3s-io:master Jan 7, 2025
26 checks passed
brandond pushed a commit to brandond/k3s that referenced this pull request Jan 10, 2025
Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 67ffd2a)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Jan 11, 2025
Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 67ffd2a)
Signed-off-by: Brad Davidson <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
dereknola added a commit to dereknola/k3s that referenced this pull request Jan 13, 2025
dereknola added a commit that referenced this pull request Jan 13, 2025
dereknola added a commit that referenced this pull request Jan 13, 2025
dereknola added a commit that referenced this pull request Jan 13, 2025
@dereknola dereknola deleted the fix_skewgo branch January 16, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants