Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Fix secrets-encrypt reencrypt timeout error #11440

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #11385

Types of Changes

Verification

Testing

Linked Issues

#11439

User-Facing Change


Further Comments

* Add missing default OS for split server test

Signed-off-by: Derek Nola <[email protected]>

* Launch go routine and return for k3s secrets-encrypt reencrypt

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner December 9, 2024 18:26
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.22%. Comparing base (666b590) to head (2734854).
Report is 1 commits behind head on release-1.29.

Files with missing lines Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11440      +/-   ##
================================================
- Coverage         46.72%   42.22%   -4.50%     
================================================
  Files               179      179              
  Lines             18720    18721       +1     
================================================
- Hits               8746     7905     -841     
- Misses             8617     9616     +999     
+ Partials           1357     1200     -157     
Flag Coverage Δ
e2etests 34.24% <0.00%> (-7.95%) ⬇️
inttests 34.77% <0.00%> (+<0.01%) ⬆️
unittests 13.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 07d60c0 into k3s-io:release-1.29 Dec 9, 2024
30 checks passed
@dereknola dereknola deleted the reencrypt_timeout_1.29 branch December 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants