Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coredns to 1.12.0 #11387

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Update coredns to 1.12.0 #11387

merged 2 commits into from
Dec 10, 2024

Conversation

unguiculus
Copy link
Contributor

@unguiculus unguiculus commented Nov 28, 2024

Proposed Changes

Update coredns to 1.12.0

This fixes the following CVS from 1.11.3:

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬─────────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                            Title                            │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼─────────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.22.5            │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message   │
│         │                │          │        │                   │                │ which contains deeply nested structures...                  │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                  │
│         ├────────────────┼──────────┤        │                   │                ├─────────────────────────────────────────────────────────────┤
│         │ CVE-2024-34155 │ MEDIUM   │        │                   │                │ go/parser: golang: Calling any of the Parse functions       │
│         │                │          │        │                   │                │ containing deeply nested literals...                        │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34155                  │
│         ├────────────────┤          │        │                   │                ├─────────────────────────────────────────────────────────────┤
│         │ CVE-2024-34158 │          │        │                   │                │ go/build/constraint: golang: Calling Parse on a "// +build" │
│         │                │          │        │                   │                │ build tag line with...                                      │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34158                  │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴─────────────────────────────────────────────────────────────┘

Linked Issues

#11450

@unguiculus unguiculus requested a review from a team as a code owner November 28, 2024 08:37
@muicoder
Copy link

It needs to be updated here as well.
https://github.com/k3s-io/k3s/blob/master/scripts/airgap/image-list.txt#L4

Signed-off-by: Reinhard Nägele <[email protected]>
@manuelbuil
Copy link
Contributor

thanks! What about moving to v1.12.0 directly?

@unguiculus
Copy link
Contributor Author

thanks! What about moving to v1.12.0 directly?

Ideally, we'd move to v1.12.0, but that's not yet mirrored by Rancher. So, I thought that would be a quicker fix to get rid of the CVEs.

@unguiculus
Copy link
Contributor Author

@manuelbuil PR for coredns 1.12.0 rancher/image-mirror#779

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.37%. Comparing base (0e15269) to head (6376b5b).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11387      +/-   ##
==========================================
- Coverage   46.73%   42.37%   -4.37%     
==========================================
  Files         179      179              
  Lines       18600    18610      +10     
==========================================
- Hits         8693     7886     -807     
- Misses       8553     9522     +969     
+ Partials     1354     1202     -152     
Flag Coverage Δ
e2etests 34.07% <ø> (-7.86%) ⬇️
inttests 34.67% <ø> (+15.85%) ⬆️
unittests 13.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unguiculus unguiculus changed the title Update coredns to 1.11.4 Update coredns to 1.12.0 Nov 28, 2024
Signed-off-by: Reinhard Nägele <[email protected]>
@unguiculus
Copy link
Contributor Author

@manuelbuil Thanks for quickly merging the PR for 1.12.0. I updated this PR now.

@dereknola dereknola merged commit 124be74 into k3s-io:master Dec 10, 2024
38 checks passed
dereknola pushed a commit to dereknola/k3s that referenced this pull request Dec 10, 2024
* Update to coredns 1.12.0

Signed-off-by: Reinhard Nägele <[email protected]>
dereknola pushed a commit to dereknola/k3s that referenced this pull request Dec 10, 2024
* Update to coredns 1.12.0

Signed-off-by: Reinhard Nägele <[email protected]>
dereknola pushed a commit to dereknola/k3s that referenced this pull request Dec 10, 2024
* Update to coredns 1.12.0

Signed-off-by: Reinhard Nägele <[email protected]>
dereknola added a commit that referenced this pull request Dec 11, 2024
* Update to coredns 1.12.0

Signed-off-by: Reinhard Nägele <[email protected]>
Co-authored-by: Reinhard Nägele <[email protected]>
@unguiculus unguiculus deleted the coredns-1.11.4 branch December 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants