Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a separate Discovery packet for P2 since some clients are lookin… #10

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

n1gp
Copy link
Contributor

@n1gp n1gp commented Jan 14, 2023

…g for a 60 byte packet.

Hi Vasiliy, I am helping to work on a new ANAN board that uses a Xilinx FPGA and a
CM4 Raspberry PI module. The main developer has implemented the Protocol 2 in a
way that strictly looks for a discovery packet of 60 bytes. This is actually what is in the
protocol documentation. Other Hermes/Orion boards are not strictly looking at packet
size and work fine with the 63 bytes.

I have tested this not only on the new ANAN board (Saturn) but also on other Hermes both
P1 and P2.

BTW, Thetis also sends both a P1 and P2 discovery packet.

Copy link
Owner

@k3it k3it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rick

Looks like a good change to comply with the Protocol 2 configuration. I see no harm with sending multiple discovery packets since the code responds as soon as a reply is received and ignores any subsequent replies. adding merge and will compile a new release soon.

Thanks for the pull request

Vasiliy K3IT

@k3it k3it merged commit 27a7acc into k3it:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants