Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] imageImport: start existing tools node before using it and add option to keep it around #672

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

iwilltry42
Copy link
Member

Title says it all..

  • if there's a tools node container, but it's not running start it, then re-use it
  • new k3d image import [-t | --keep-tools] flag to not delete the tools node after importing the image (so it can be re-used in the next round of imports)

Potentially fixes #671

@iwilltry42 iwilltry42 self-assigned this Jul 9, 2021
@iwilltry42 iwilltry42 added this to the v4.4.7 milestone Jul 9, 2021
@iwilltry42 iwilltry42 added bug Something isn't working component/main enhancement New feature or request priority/medium scope/cli Issue concerns the CLI (cmd/) scope/package pkg/ labels Jul 9, 2021
@iwilltry42 iwilltry42 merged commit c5f7884 into main Jul 9, 2021
@iwilltry42 iwilltry42 deleted the fix/import-image-tools-not-running branch July 9, 2021 06:22
rancherio-gh-m pushed a commit that referenced this pull request Jul 9, 2021
Author: Thorsten Klein <[email protected]>
Date:   Fri Jul 9 08:22:05 2021 +0200

    [ENHANCEMENT] imageImport: start existing tools node before using it and add option to keep it around (#672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/main enhancement New feature or request priority/medium scope/cli Issue concerns the CLI (cmd/) scope/package pkg/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] image import fails with "Failed to create exec config for node"
1 participant