Development #5
Merged
Development #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find myself typing ls often by accident.
… timeout Signed-off-by: Rishabh Gupta <[email protected]>
Added version tags, separated command implementaitons, added wait and…
zeerorg
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
This looks good. I haven't tested the exact pr since I am a bit busy at the moment. Can you take a quick test for the PR?
About my changes,
- added a
--waitflag and a--timeoutflag to create cluster - the version in the cli is fetched automatically.
If the program compiles and these two changes along with your changes work prefectly then it should go as a new release.
|
@zeerorog I tested this PR about an hour ago. Version detection and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zeerorg & @ibuildthecloud