Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Calico installation steps in the docs #1523

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

frozenprocess
Copy link
Contributor

What

  • This update moves Calico to an operator based installer.
  • Removes the calico.yaml since it is not the recommended way.

Why

#1325
#1375

Implications

Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
Just one non-blocking question

@@ -29,58 +15,51 @@ So the command of the cluster creation is (when you are at root of the k3d repos

```bash
k3d cluster create "${clustername}" \
--k3s-arg '--flannel-backend=none@server:*' \
--k3s-arg '--flannel-backend=none@server:*' --no-lb \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the LB have to be disabled?

Copy link
Contributor Author

@frozenprocess frozenprocess Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D Because I'm a fan of copy, paste and use a local loadbalancer.
I've changed the creation step to include load balancer and modified some of the texts to help people know why we are doing some of the stuff in each steps.
thanks for the reviews!

This update moves Calico to an operator based installer.
Removes the `calico.yaml` since it is not the recommended way.
What's next section.
@iwilltry42
Copy link
Member

Love the extra ads for other guides at the end 😁

Thanks for this PR!

@iwilltry42 iwilltry42 merged commit bdaf643 into k3d-io:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants