-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Calico installation steps in the docs #1523
Conversation
24531f8
to
0fb2a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Just one non-blocking question
docs/usage/advanced/calico.md
Outdated
@@ -29,58 +15,51 @@ So the command of the cluster creation is (when you are at root of the k3d repos | |||
|
|||
```bash | |||
k3d cluster create "${clustername}" \ | |||
--k3s-arg '--flannel-backend=none@server:*' \ | |||
--k3s-arg '--flannel-backend=none@server:*' --no-lb \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the LB have to be disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D Because I'm a fan of copy, paste and use a local loadbalancer.
I've changed the creation step to include load balancer and modified some of the texts to help people know why we are doing some of the stuff in each steps.
thanks for the reviews!
0fb2a21
to
dbed254
Compare
This update moves Calico to an operator based installer. Removes the `calico.yaml` since it is not the recommended way. What's next section.
dbed254
to
95430dc
Compare
Love the extra ads for other guides at the end 😁 Thanks for this PR! |
What
calico.yaml
since it is not the recommended way.Why
#1325
#1375
Implications