-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyword spotting. #1689
Fix keyword spotting. #1689
Conversation
See also k2-fsa#1417
also, fixes #1235 @carcloudfly @yuyun2000 |
This is cool, we recently discovered the blank parameter issue, but haven’t confirmed it yet. |
cool! please supplement the API for JNI / Java / Kotlin. thanks. |
Windowsd demo已经解决,wasm场景还未解决问题,使用的是 https://github.com/csukuangfj/sherpa-onnx/tree/fix-kws 分支编译的,结果如下
|
可否帮忙再测试下? wasm 例子,应该也修复了。 |
@brekov Done. Please re-try. |
See also #1417
Fixes #1417
CC @codepubs @brekov
I think there is a bug in keyword spotting.
After the keyword is detected, the result.num_trailing_blanks of subsequent calls with
Decode()
is always 0.This PR resets the stream after detecting a keyword to avoid that (Users should call it manually).
Also, it resets the stream automatically after detecting 1.5 seconds of silence.